Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #381: Rename linelist argument to data #437

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Issue #381: Rename linelist argument to data #437

merged 2 commits into from
Nov 15, 2024
+7 −7

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Nov 14, 2024 •
edited
Loading

Description

This PR closes #381.

The only case where something is called linelist are this simulation function, and the observe_process function. We are expecting to remove observe_process with issue #431.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs November 14, 2024 16:53
@athowes athowes marked this pull request as ready for review November 15, 2024 10:34
@seabbs seabbs enabled auto-merge (squash) November 15, 2024 10:39
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.11%. Comparing base (d02c7c7) to head (0ba1076).
Report is 51 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
+ Coverage   88.55%   94.11%   +5.56%     
==========================================
  Files          11       16       +5     
  Lines         402      425      +23     
==========================================
+ Hits          356      400      +44     
+ Misses         46       25      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs merged commit b899cdb into main Nov 15, 2024
9 checks passed
@seabbs seabbs deleted the data-not-linelist branch November 15, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardise linelist and data names
2 participants
@athowes @seabbs